Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix extra empty page in UG. #264

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Fix extra empty page in UG. #264

merged 1 commit into from
Apr 15, 2024

Conversation

NeoHW
Copy link

@NeoHW NeoHW commented Apr 15, 2024 •
edited
Loading

Fixes #265

@NeoHW NeoHW added type.Documentation Improvements or additions to documentation priority.High Must do labels Apr 15, 2024
@NeoHW NeoHW added this to the v1.4 milestone Apr 15, 2024
@NeoHW NeoHW self-assigned this Apr 15, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.16%. Comparing base (1bde388) to head (c76dbe4).
Report is 4 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master     #264   +/-   ##
=========================================
  Coverage     82.16%   82.16%           
  Complexity      743      743           
=========================================
  Files            96       96           
  Lines          2287     2287           
  Branches        239      239           
=========================================
  Hits           1879     1879           
  Misses          350      350           
  Partials         58       58

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

SherisseTJW
SherisseTJW approved these changes Apr 15, 2024
View reviewed changes
Copy link
Collaborator

@SherisseTJW SherisseTJW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SherisseTJW SherisseTJW merged commit 4000346 into AY2324S2-CS2103-F09-2:master Apr 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SherisseTJW SherisseTJW SherisseTJW approved these changes

Assignees

@NeoHW NeoHW

Labels
priority.High Must do type.Documentation Improvements or additions to documentation
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

Extra Blank Page in UG pdf format
2 participants
@NeoHW @SherisseTJW