Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize formatting in UG #200

Merged
merged 25 commits into from
Apr 12, 2024
Merged

Conversation

erv-teo
Copy link

@erv-teo erv-teo commented Apr 12, 2024

This PR also

  • fixes a minor typo in the DG
  • changes the UML diagram to use a better resolution

Copy link

@ejnan ejnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the format for Caution with ** at the sides

@@ -382,7 +416,9 @@ On entering the `help` command, the following window will pop up:

Allows you to clear all entries from the address book.

<div markdown="span" class="alert alert-warning">
:exclamation: **Caution:** This action is irreversible.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Caution is not bolded and users can see **, which may be due to spaces. The formatting for the boxes will probably only be seen once merged

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On my screen the display looks fine, maybe we can merge and see if the problem still persists?
Screenshot 2024-04-12 at 16 29 24

Copy link

@ryanlimdx ryanlimdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryanlimdx ryanlimdx merged commit 7998875 into AY2324S2-CS2103T-F10-1:master Apr 12, 2024
3 checks passed
@iamtr iamtr added this to the v1.4 milestone Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants