Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add character limit to String parameters and fix formatting #206

Merged
merged 3 commits into from
Apr 13, 2024

Conversation

ejnan
Copy link

@ejnan ejnan commented Apr 12, 2024

No description provided.

| **REMARK** | Optional remark about a patient. | Any string input, e.g., `Patient is an amputee`. |
| **TAG** | Optional tag to categorize a patient by health condition or other descriptors. | An alphanumeric string for each tag, e.g., `Diabetes`. Note that special characters are not allowed, and you can work around this issue by omitting special characters, utilising [camelCase](#glossary) or [PascalCase](#glossary) e.g., `FallRisk`. |
| **TAG** | Optional tag to categorize a patient by health condition or other descriptors. | An alphanumeric string for each tag, e.g., `Diabetes`. Note that special characters are not allowed, and you can work around this issue by omitting special characters, utilising [camelCase](#glossary) or [PascalCase](#glossary) e.g., `FallRisk`. <br><br> **Tags are limited to 15 characters. Longer tags may not display fully in the GUI.** |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could phrase it as names SHOULD BE, tags SHOULD BE. Otherwise during testing they may report a bug where an error is not thrown even though it exceeded the character limit.

Copy link

@swtan346 swtan346 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ejnan ejnan merged commit 4675b32 into AY2324S2-CS2103T-F10-1:master Apr 13, 2024
3 checks passed
@iamtr iamtr added this to the v1.4 milestone Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PE-D][Tester D] Full long tag not fully displayed [PE-D][Tester D] Long Name not displayed fully
4 participants