Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add use case, reduce NFR in DG #214

Merged
merged 5 commits into from
Apr 14, 2024

Conversation

swtan346
Copy link

No description provided.

Copy link

@iamtr iamtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes may be required

Comment on lines +629 to +637
1. A user with above average typing speed for regular English text (i.e. not code, not system admin commands)
should be able to accomplish most of the tasks faster using commands than using the mouse.
1. The codebase should be well-structured and well-documented to facilitate future maintenance and enhancements.
1. The application should only support a single user.
1. The data should be stored locally and should be in a human editable text file.
1. The software should work without requiring an installer.
1. The software should not depend on any specific remote server.
1. The product should be available as a single JAR file of size 100MB or below.
1. The product should process a user input command within 2 second.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

numbering here is incorrect

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

markdown coding standard

image

@@ -523,13 +523,13 @@ specified otherwise)
* 2a. The given index is invalid.
* 2a2. AddressBook shows an error message.

Use case resumes at step 2.
Use case ends.

**Use case: `US04 - Edit a patient records`**
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be UC instead of US

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link

@erv-teo erv-teo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erv-teo erv-teo merged commit f8c9d91 into AY2324S2-CS2103T-F10-1:master Apr 14, 2024
3 checks passed
@iamtr iamtr added this to the v1.4 milestone Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants