Update AddCommand.java params #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into addCommandParams
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #28 +/- ##
============================================
- Coverage 75.33% 72.50% -2.83%
- Complexity 419 438 +19
============================================
Files 71 75 +4
Lines 1342 1495 +153
Branches 126 148 +22
============================================
+ Hits 1011 1084 +73
- Misses 301 360 +59
- Partials 30 51 +21 ☔ View full report in Codecov by Sentry. |
ejnan
reviewed
Mar 15, 2024
| + PREFIX_ADDRESS + "ADDRESS " | ||
| + PREFIX_IC + "IC " | ||
| + PREFIX_DOB + "DOB " | ||
| + PREFIX_ADMISSION_DATE + "EMAIL " |
erv-teo
reviewed
Mar 15, 2024
| @@ -23,20 +24,21 @@ public class AddCommand extends Command { | |||
| public static final String MESSAGE_USAGE = COMMAND_WORD + ": Adds a person to the address book. " | |||
| + "Parameters: " | |||
| + PREFIX_NAME + "NAME " | |||
| + PREFIX_PHONE + "PHONE " | |||
| + PREFIX_EMAIL + "EMAIL " | |||
There was a problem hiding this comment.
Should we include the optional fields in MESSAGE_USAGE as well? like phone, email, address
Since we include tags as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.