-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update UI for AddCommand #29
Update UI for AddCommand #29
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #29 +/- ##
============================================
+ Coverage 75.26% 75.47% +0.21%
- Complexity 419 460 +41
============================================
Files 71 75 +4
Lines 1338 1513 +175
Branches 126 154 +28
============================================
+ Hits 1007 1142 +135
- Misses 301 323 +22
- Partials 30 48 +18 ☔ View full report in Codecov by Sentry. |
<Label fx:id="address" styleClass="cell_small_label" text="\$address" /> | ||
<Label fx:id="email" styleClass="cell_small_label" text="\$email" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe remove the unnecessary prefixes - address, email and phone?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #24