Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UI for AddCommand #29

Merged
merged 12 commits into from
Mar 20, 2024

Conversation

erv-teo
Copy link

@erv-teo erv-teo commented Mar 15, 2024

Closes #24

@erv-teo erv-teo changed the title Branch add command UI Update UI for AddCommand Mar 15, 2024
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 77.40113% with 40 lines in your changes are missing coverage. Please review.

Project coverage is 75.47%. Comparing base (7e024e1) to head (dfb0f6c).
Report is 69 commits behind head on master.

Files Patch % Lines
.../java/seedu/address/storage/JsonAdaptedPerson.java 55.17% 7 Missing and 6 partials ⚠️
.../java/seedu/address/model/util/SampleDataUtil.java 0.00% 7 Missing ⚠️
...in/java/seedu/address/logic/parser/ParserUtil.java 66.66% 3 Missing and 3 partials ⚠️
...c/main/java/seedu/address/model/person/Person.java 75.00% 1 Missing and 4 partials ⚠️
...java/seedu/address/logic/commands/EditCommand.java 87.09% 0 Missing and 4 partials ⚠️
src/main/java/seedu/address/ui/PersonCard.java 0.00% 4 Missing ⚠️
src/main/java/seedu/address/model/person/Ic.java 92.85% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #29      +/-   ##
============================================
+ Coverage     75.26%   75.47%   +0.21%     
- Complexity      419      460      +41     
============================================
  Files            71       75       +4     
  Lines          1338     1513     +175     
  Branches        126      154      +28     
============================================
+ Hits           1007     1142     +135     
- Misses          301      323      +22     
- Partials         30       48      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines 36 to 37
<Label fx:id="address" styleClass="cell_small_label" text="\$address" />
<Label fx:id="email" styleClass="cell_small_label" text="\$email" />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe remove the unnecessary prefixes - address, email and phone?

Copy link

@ejnan ejnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@ejnan ejnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iamtr iamtr merged commit 938fb4c into AY2324S2-CS2103T-F10-1:master Mar 20, 2024
5 checks passed
@erv-teo erv-teo added this to the v1.2 milestone Mar 21, 2024
@erv-teo erv-teo self-assigned this Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Add Command] Modify UI to support updated parameters
3 participants