Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix success message for Add Command #32

Merged
merged 8 commits into from
Mar 21, 2024

Conversation

erv-teo
Copy link

@erv-teo erv-teo commented Mar 20, 2024

Change message to display correct fields, add a newline to each field, and add titles to fields for stored contacts.

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 75.52%. Comparing base (938fb4c) to head (c220065).
Report is 2 commits behind head on master.

Files Patch % Lines
src/main/java/seedu/address/ui/PersonCard.java 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #32      +/-   ##
============================================
+ Coverage     75.47%   75.52%   +0.04%     
  Complexity      460      460              
============================================
  Files            75       75              
  Lines          1513     1516       +3     
  Branches        154      154              
============================================
+ Hits           1142     1145       +3     
  Misses          323      323              
  Partials         48       48              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@iamtr iamtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@iamtr iamtr merged commit 7689dbe into AY2324S2-CS2103T-F10-1:master Mar 21, 2024
4 of 5 checks passed
@erv-teo erv-teo added this to the v1.2 milestone Mar 21, 2024
@erv-teo erv-teo self-assigned this Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants