Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Developer Guide to include Help Command #57

Merged
merged 4 commits into from
Apr 2, 2024

Conversation

ejnan
Copy link

@ejnan ejnan commented Mar 28, 2024

No description provided.

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.82%. Comparing base (7eb89ab) to head (86291b3).

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #57   +/-   ##
=========================================
  Coverage     74.82%   74.82%           
  Complexity      431      431           
=========================================
  Files            72       72           
  Lines          1394     1394           
  Branches        134      134           
=========================================
  Hits           1043     1043           
  Misses          314      314           
  Partials         37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iamtr iamtr mentioned this pull request Mar 29, 2024
Copy link

@ryanlimdx ryanlimdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need to reflect additional parameters based on v1.3. Otherwise can leave as v1.2's implementation for now I think.

Find: find KEYWORD [MORE_KEYWORDS]
Example: find John

List: list

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps can include [t\TAG_KEYWORDS], [w\WARD_KEYWORD] for list as well!

@@ -265,3 +303,10 @@ Action | Format, Examples
**Edit** | `edit INDEX [n\NAME] [ic\IC_NUMBER] [dob\DATE_OF_BIRTH] [ad\ADMISSION_DATE] [w\WARD] [t\TAG]…​`<br> e.g.,`edit 2 n\James Lee w\A2`
**Find** | `find KEYWORD [MORE_KEYWORDS]`<br> e.g., `find James Jake`
**List** | `list`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, can update the optional parameters here too. Thank you!

@@ -168,7 +172,7 @@ Ward: A1
Tags:
```

### Locating persons by name: `find`
### Locating patients by name: `find`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May need to update this to reflect ShaoWei's find update as well

@iamtr iamtr added this to the v1.3 milestone Mar 29, 2024
Copy link

@iamtr iamtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iamtr iamtr merged commit 4c97943 into AY2324S2-CS2103T-F10-1:master Apr 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants