Skip to content

Commit

Permalink
Merge branch 'branch-code-name' of https://github.com/PateShin/tp int…
Browse files Browse the repository at this point in the history
…o branch-code-name
  • Loading branch information
PateShin committed Mar 21, 2024
2 parents fb44df8 + 69836eb commit e01290c
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 2 deletions.
1 change: 1 addition & 0 deletions docs/diagrams/BetterModelClassDiagram.puml
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,5 @@ Person *--> Name
Person *--> Phone
Person *--> Email
Person *--> Address
Person *--> YearJoined
@enduml
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ public void execute_filteredList_success() {
@Test
public void execute_duplicatePersonUnfilteredList_failure() {
Person firstPerson = model.getFilteredPersonList().get(INDEX_FIRST_PERSON.getZeroBased());

EditPersonDescriptor descriptor = new EditPersonDescriptorBuilder(firstPerson).withName("Benson Meier").build();

EditCommand editCommand = new EditCommand(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -157,8 +157,8 @@ public void parse_invalidValue_failure() {
+ TAG_DESC_HUSBAND + TAG_DESC_FRIEND, Email.MESSAGE_CONSTRAINTS);

// invalid address
assertParseFailure(parser, NAME_DESC_BOB + PHONE_DESC_BOB + EMAIL_DESC_BOB + YEARJOINED_DESC_BOB
+ INVALID_ADDRESS_DESC + TAG_DESC_HUSBAND + TAG_DESC_FRIEND, Address.MESSAGE_CONSTRAINTS);
assertParseFailure(parser, NAME_DESC_BOB + PHONE_DESC_BOB + EMAIL_DESC_BOB + INVALID_ADDRESS_DESC
+ YEARJOINED_DESC_BOB + TAG_DESC_HUSBAND + TAG_DESC_FRIEND, Address.MESSAGE_CONSTRAINTS);

// invalid tag
assertParseFailure(parser, NAME_DESC_BOB + PHONE_DESC_BOB + EMAIL_DESC_BOB + ADDRESS_DESC_BOB
Expand Down

0 comments on commit e01290c

Please sign in to comment.