Change the DNMD APIs to act on single rows and bring other perf improvements from the CoreCLR + DNMD experiment to DNMD. #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vements from the CoreCLR + DNMD experiment to DNMD.
…s successful so compiler control flow analysis doesn't see fcxt as uninitialized.
AaronRobinsonMSFT
approved these changes
Oct 17, 2024
jkoritzinsky
added a commit
to jkoritzinsky/runtime
that referenced
this pull request
Oct 17, 2024
…vements from the CoreCLR + DNMD experiment to DNMD. Port of AaronRobinsonMSFT/DNMD#55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the various DNMD column reading/writing APIs to act primarily on 1 row instead of being designed primarily for bulk processing. The vast majority of usages are for single-row operations.
Also bring back a variety of different optimizations that (all in combination and with the changes above) gets an implementation of CoreCLR's
IMDInternalImportfor read-only usage to be almost 2% faster in my local benchmark.I'm not bringing that interface into DNMD with this PR as that implementation also requires changes to
IMDInternalImportto support DNMD's implementation (and as a result is not compatible with stock CoreCLR). Additionally,IMDInternalImport's implementation is (as the name implies) internal to CoreCLR and not intended for public consumption.When bringing DNMD into CoreCLR, I'll include the implementation with the requisite changes.