Tweak CI: remove on push for PRs and add names to CI steps #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense! |
jby-ableton
approved these changes
Jul 4, 2024
MattijsKneppers
force-pushed
the
mkp-tweak-ci
branch
from
dd3c664
to
e272c7b
Compare
|
A good point from @ala-ableton: when removing the |
We included `push` to make sure PRs get tested when new commits were added or the commit history was changed. However, it appears that for an active PR, every push already causes a `synchronize` activity type for the `pull_request_target` event. So the `push` event is no longer needed for every PR. Instead, this sets it to trigger only for the case when something was pushed directly to `main`. See: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target
MattijsKneppers
force-pushed
the
mkp-tweak-ci
branch
from
e272c7b
to
239cf9b
Compare
MattijsKneppers
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We originally included
pushto make sure PRs get tested when new commits are added or existing commits are changed.However, it appears that for an active PR, every push already causes a
synchronizeactivity type for thepull_request_targetevent, which triggers the workflow. See thepull_request_targetdocumentation.So the
pushevent is no longer needed for PRs. Instead, we set it to trigger only for the case when something was pushed directly to themainbranch as documented here.Also adds names to CI steps like in GitHub's examples.