Upgrade embedded-postgres plugin and binaries. #1262
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link the Issue(s) this Pull Request is related to.
Fixes #1196.
Summarize your change.
The existing embedded-postgres we're using is old and does not support arm64v8 architecture.
Previously, newer binaries would produce unusual results on arm64v8+Docker -- see zonkyio/embedded-postgres#99 for more details.
That issue is now fixed, and new binaries have been published.
This change still requires us to update one query with a
CASTtonumeric. However this query fails in the same way both within and without of Docker, so I believe it is related to the new Postgres version rather than the previously mentioned embedded-postgres issue.