-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial data track support #1362
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Roy Turner <[email protected]>
Signed-off-by: Roy Turner <[email protected]>
@@ -880,6 +880,8 @@ def _transcribe(item, parents, edit_rate, indent=0): | |||
result.kind = otio.schema.TrackKind.Video | |||
elif media_kind in ("SoundMasterTrack", "Sound"): | |||
result.kind = otio.schema.TrackKind.Audio | |||
elif media_kind == "Descriptive Metadata": | |||
result.kind = otio.schema.TrackKind.Data | |||
else: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Descriptive Metadata
is not the media kind for the Data tracks your referring too. The media kind for the Data track is DataEssenceTrack
.
@@ -1595,6 +1619,9 @@ def read_from_file( | |||
if simplify: | |||
result = _simplify(result) | |||
|
|||
# Make sure that any AAF Data tracks are marked as such | |||
result = _update_kind_of_data_tracks(result) | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AAF's store markers on special slots called EventMobSlots
. The markers on these slots reference the slot(s) they are actually on by their DescribedSlots
property. The_attach_markers
function already does this resolving, so _update_kind_of_data_tracks
should not be needed.
I edited the description to activate the link to the ongoing discussion in issue #1361 |
@redroy @timlehr May I close this PR and as you pick it up again you can open a new PR over at OpenTimelineIO/otio-aaf-adapter? |
Fine by me, but Tim should make the call as he has picked up this issue. Sent from my iPhone.On Oct 27, 2023, at 1:31 PM, Eric Reinecke ***@***.***> wrote:
@redroy @timlehr May I close this PR and as you pick it up again you can open a new PR over at OpenTimelineIO/otio-aaf-adapter?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Link the Issue(s) this Pull Request is related to.
Fixes #1361
Added track type 'Data'. Add support for reading AAF data tracks.
Our editors use markers on the Data Track to mark shot breaks and other significant events.
Added test AAFReaderTests.test_aaf_data_track_markers()