Initial data track support #1362
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meshula
added
TSC
jminor
reviewed
Jul 26, 2022
Signed-off-by: Roy Turner <[email protected]>
Signed-off-by: Roy Turner <[email protected]>
markreidvfx
reviewed
Jul 31, 2022
| @@ -880,6 +880,8 @@ def _transcribe(item, parents, edit_rate, indent=0): | |||
| result.kind = otio.schema.TrackKind.Video | |||
| elif media_kind in ("SoundMasterTrack", "Sound"): | |||
| result.kind = otio.schema.TrackKind.Audio | |||
| elif media_kind == "Descriptive Metadata": | |||
| result.kind = otio.schema.TrackKind.Data | |||
| else: | |||
There was a problem hiding this comment.
Descriptive Metadata is not the media kind for the Data tracks your referring too. The media kind for the Data track is DataEssenceTrack.
markreidvfx
reviewed
Jul 31, 2022
| @@ -1595,6 +1619,9 @@ def read_from_file( | |||
| if simplify: | |||
| result = _simplify(result) | |||
|
|
|||
| # Make sure that any AAF Data tracks are marked as such | |||
| result = _update_kind_of_data_tracks(result) | |||
|
|
|||
There was a problem hiding this comment.
AAF's store markers on special slots called EventMobSlots. The markers on these slots reference the slot(s) they are actually on by their DescribedSlots property. The_attach_markers function already does this resolving, so _update_kind_of_data_tracks should not be needed.
|
I edited the description to activate the link to the ongoing discussion in issue #1361 |
reinecke
added
the
Adapters
|
@redroy @timlehr May I close this PR and as you pick it up again you can open a new PR over at OpenTimelineIO/otio-aaf-adapter? |
|
Fine by me, but Tim should make the call as he has picked up this issue. Sent from my iPhone.On Oct 27, 2023, at 1:31 PM, Eric Reinecke ***@***.***> wrote:
@redroy @timlehr May I close this PR and as you pick it up again you can open a new PR over at OpenTimelineIO/otio-aaf-adapter?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link the Issue(s) this Pull Request is related to.
Fixes #1361
Added track type 'Data'. Add support for reading AAF data tracks.
Our editors use markers on the Data Track to mark shot breaks and other significant events.
Added test AAFReaderTests.test_aaf_data_track_markers()