adding bookmarking functionality #407
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![accesslint[bot]](https://avatars.githubusercontent.com/in/1502?s=60&v=4){kind=small}
ordering/templates/index.html
Outdated
| @@ -171,6 +172,7 @@ | |||
| <tbody> | |||
| {% for row in table_content %} | |||
| <tr class="episode {{ series_map[row.series].id }}"> | |||
| <td><input type='checkbox' data-episodeId="{{ row.series }} {{ row.episode_id }}" onclick="(event) => bookmarkEpisode(event)"/></td> | |||
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
Signed-off-by: Qamar Stationwala <[email protected]>
Signed-off-by: Qamar Stationwala <[email protected]>
…hing is pointless Signed-off-by: Qamar Stationwala <[email protected]>
Signed-off-by: Qamar Stationwala <[email protected]>
|
@AceFire6 got time to check out this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I wasn't able to test it because I am not that well versed in python. I am fairly certain I installed all the right packages but after running the server, attempting to access the page was met with Error 10061 connecting to localhost:6379. No connection could be made because the target machine actively refused it.
That being said, it is purely a frontend change and I am fairly certain this should work. The exact function does work when I use it with tampermonkey, so the logic of the JS is sound. Only question is whether I properly edited your html template :)