Sharrow Cache Dir Setting #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpn--
reviewed
Oct 3, 2024
| @@ -478,15 +478,12 @@ def load_settings(self) -> State: | |||
| include_stack=False, | |||
| ) | |||
|
|
|||
| # the settings can redefine the cache directories. | |||
| cache_dir = raw_settings.pop("cache_dir", None) | |||
There was a problem hiding this comment.
We used "pop" here, this takes this setting off the raw_settings. The revision leaves the setting in place... should we be popping all these values?
I think we need to write a test [or tests] to make sure this is solving the problem well.
|
This appears to work. We need to have a test to confirm that, but writing one is some effort and in the meantime consortium members will benefit from having this fixed. I opened #902 to record that we want this tested, and will merge this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #890. Also fixes the same issue for
profile_dirandpipeline_file_namesettings.