Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken relative links #238

Merged
merged 2 commits into from
Jul 12, 2024
Merged

Fix broken relative links #238

merged 2 commits into from
Jul 12, 2024

Conversation

keharper
Copy link
Contributor

Purpose of this pull request

This pull request (PR) fixes a pair of relative links that don't resolve for some reason.

Affected pages

  • ...

Links to Magento Open Source code

  • ...

@keharper keharper self-assigned this Jul 11, 2024
@keharper keharper added bug Something isn't working internal Differentiates work between external and internal contributors labels Jul 11, 2024
jhadobe
jhadobe approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@jhadobe jhadobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might try a longer relative path. it would make it easier to catch link checker errors in the future. e.g. ../../extension-points/index.md#xyz. not a blocker, though.

@keharper keharper merged commit ec7fda4 into main Jul 12, 2024
5 checks passed
@keharper keharper deleted the kh_mass-action-link branch July 12, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhadobe jhadobe jhadobe approved these changes

Assignees

@keharper keharper

Labels
bug Something isn't working internal Differentiates work between external and internal contributors
Projects
Commerce - Pull Requests
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keharper @jhadobe