Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Callback function is not exist #875

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cagdasdag
Copy link

We don't have save_post method inside this class but we are using the hook without having a callback method. I checked the history couldn't see any reference to this, so I feel like this is a forgotten code for a long time 🤔

@lgladdy
Copy link
Member

lgladdy commented Sep 12, 2023

Thanks for the report here. This isn't legacy code (in fact, it'a new with ACF 6!) but rather there are no instances of ACF_Admin_Internal_Post_Type instead this class is extended by each of the ACF types.

We'll fix this either by making it an abstract class or by adding a blank stub function like we do the functions admin_head etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants