[ECP-9491] Refactor instantiating AdyenCheckout library and components #2770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
candemiralp
had a problem deploying
to
internal
GitHub Actions
Failure
This was referenced Oct 14, 2024
khushboo-singhvi
previously approved these changes
Oct 15, 2024
peterojo
previously approved these changes
Oct 15, 2024
candemiralp
dismissed stale reviews from peterojo and khushboo-singhvi
via
4079d69
candemiralp
had a problem deploying
to
internal
GitHub Actions
Failure
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
candemiralp
had a problem deploying
to
internal
GitHub Actions
Failure
candemiralp
had a problem deploying
to
internal
GitHub Actions
Failure
|
Please retry analysis of this Pull-Request directly on SonarCloud |
candemiralp
had a problem deploying
to
internal
GitHub Actions
Failure
|
peterojo
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The plugin currently builds
AdyenCheckoutlibrary object as much as the number of the payment methods enabled on the checkout and mounts all of the payment components at the same time after rendering the checkout.This results in delays on the checkout since
AdyenCheckoutlibrary makes multiple calls tocheckoutshopperendpoints after instantiation for collecting data for risk calculation. This causes a drastic performance degradation on the checkout page.Ideally,
AdyenCheckoutlibrary object should be instantiated after a shopper selects an Adyen payment method. This PR introduces a refactoring which changes the logic of instantiating theAdyenCheckoutlibrary and mount payment method components.Tested scenarios
checkoutshoppercheckoutshoppercheckoutshopperendpoint is not called if no Adyen payment method is selectedFixes #2766
Fixes #2581