Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abrar/mysqlconnector/affirm 3.3.2 #25

Merged

Conversation

abrarsher23
Copy link

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

Copy link
Member

@nickwu241 nickwu241 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How much larger did the package become?

@@ -437,6 +437,11 @@
<artifactId>tabular-client-runtime</artifactId>
<version>1.18.4</version>
</dependency>
<dependency>
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will attempt removing this

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

definitely need this!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just tested without it and it did not work

@rayhondo rayhondo merged commit 4ff19e7 into Affirm:affirm-3.3.2 Nov 17, 2023
2 of 3 checks passed
rayhondo added a commit that referenced this pull request Mar 12, 2024
* added mysql connector

* added

* dev16

* Update version.py

---------

Co-authored-by: Ray Kim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants