[DRPT] Affirm 3.3.2 line sep feature #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What changes were proposed in this pull request? Univocity parser allows to set line separator to 1 to 2 characters ([code](https://github.com/uniVocity/univocity-parsers/blob/master/src/main/java/com/univocity/parsers/common/Format.java#L103)), CSV options should not block this usage ([code](https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/CSVOptions.scala#L218)). This PR updates the requirement of `lineSep` accepting 1 or 2 characters in `CSVOptions`. Due to the limitation of supporting multi-chars `lineSep` within quotes, I propose to leave this feature undocumented and add a WARN message to users. ### Why are the changes needed? Unblock the usability of 2 characters `lineSep`. ### Does this PR introduce _any_ user-facing change? No - undocumented feature. ### How was this patch tested? New UT. Closes apache#37107 from Yaohua628/spark-39689. Lead-authored-by: yaohua <[email protected]> Co-authored-by: Yaohua Zhao <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
m-aciek
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRPT-913
Adding feature from 3.4 which allows to define \r\n line terminator before writing to csv files.
cherry picked from https://github.com/Affirm/all-the-things/pull/69877/files#diff-7c9bbec295689aae23a0cd057a7de14e12c373fa7e22b0c9439abe9770ef343f