CI improvements #40
Merged
CI improvements #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rabi-siddique
force-pushed
the
rs-ci-enhancements
branch
from
65982a2 to
6f2003c
Compare
Muneeb147
reviewed
Dec 24, 2024
| - name: Notify About Failure | ||
| if: > | ||
| failure() && github.event_name != 'pull_request' && | ||
| github.repository_owner == 'agoric' |
There was a problem hiding this comment.
Why this check? To avoid running it in fork repos?
There was a problem hiding this comment.
To reduce distractions during development, notifications are restricted to only scheduled runs or manual triggers.
There was a problem hiding this comment.
To avoid running it in fork repos?
I reckon you're referring to github.repository_owner == 'agoric'? The condition github.repository_owner == 'agoric' is actually used in the agoric-sdk workflows primarily for Slack notifications, which is why I decided to adopt it. Not to avoid running it in fork repos.
Muneeb147
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR does the following:
mainbranch.