Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove flaky expected values #42

Merged
merged 1 commit into from
Dec 26, 2024
Merged

test: remove flaky expected values #42

merged 1 commit into from
Dec 26, 2024

Conversation

rabi-siddique
Copy link
Collaborator

@rabi-siddique rabi-siddique commented Dec 26, 2024

The PR temporarily removes the value field from reserveAllocationMetrics and the valueLast field from reserveAllocationMetricsDailies expected values.

@rabi-siddique
Copy link
Collaborator Author

It's weird that this test failed suddenly. I am inspecting the reason for the failure. @frazarshad any pointers?

@rabi-siddique rabi-siddique changed the title test: change expected values test: remove flaky expected values Dec 26, 2024
@rabi-siddique rabi-siddique merged commit 02ec75b into main Dec 26, 2024
2 of 3 checks passed
@rabi-siddique rabi-siddique deleted the rs-fix-test branch December 26, 2024 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants