feat: create initial skeleton for dapp-agoric-basics #1
Conversation
| import '@endo/init'; | ||
| import { E } from '@endo/far'; | ||
| // eslint-disable-next-line import/no-unresolved -- https://github.com/avajs/ava/issues/2951 | ||
| import test from 'ava'; |
There was a problem hiding this comment.
I think we might need to do import { test } from '@agoric/zoe/tools/prepare-test-env-ava.js';... but I am not up to date on latest best practices here and could use a 2nd opinion.
There was a problem hiding this comment.
| "eslintConfig": { | ||
| "parserOptions": { | ||
| "sourceType": "module", | ||
| "ecmaVersion": 2021 | ||
| }, | ||
| "extends": [ | ||
| "@agoric" | ||
| ] | ||
| }, |
There was a problem hiding this comment.
This looks good. As a heads up, dapp-offer-up has a backlog item to expand this configuration to include type checking, and no-void + no-floating-promises rules: Agoric/dapp-offer-up#35 (comment)
This has been blocked by lack of type support in the current releases, which prevents us from checking this sort of thing into CI: Agoric/dapp-offer-up#31 (This assumption may need to be revisited, as the two eslint rules seem separate from typechecking)
There was a problem hiding this comment.
Got it, created #2 to track this
| "useWorkspaces": true, | ||
| "workspaces": [ | ||
| "contract" | ||
| ], |
There was a problem hiding this comment.
Hm. no endo resolutions to work around Agoric/agoric-sdk#8621
I was expecting something started with yarn create @agoric/dapp --dapp-template dapp-offer-up with support for starting the chain in docker, deploying the contract, testing that it's not >1MB compressed, etc.
There was a problem hiding this comment.
added an issue:
|
Closing this as we decided to use |
references: Agoric/documentation#938
Summary
This PR creates the minimal skeleton for dapp-agoric-basics, including rudimentary CI.
This PR does not contain any UI code as I'm planning to use ui-kit and hoping to follow docs produced as part of Agoric/documentation#922
Testing
On my local machine:
yarn lintyarn test