chore: logging stdout and stderr

Agoric · Oct 11, 2024 · e2ed085 · e2ed085
1 parent 815c768
commit e2ed085
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 17 deletions.
diff --git a/test/e2e/specs/liquidation-reconstitution.spec.js b/test/e2e/specs/liquidation-reconstitution.spec.js
@@ -413,16 +413,6 @@ describe('Wallet App Test Cases', () => {
       taskTimeout: DEFAULT_TASK_TIMEOUT,
     },
     () => {
-      it('should create a vault minting 400 ISTs and giving 80 ATOMs as collateral', () => {
-        cy.skipWhen(AGORIC_NET !== networks.LOCAL);
-
-        cy.createVault({
-          wantMinted: 400,
-          giveCollateral: 80,
-          userKey: 'gov1',
-        });
-      });
-
       it('should save bidder ATOM balance before placing bids', () => {
         cy.wait(QUICK_WAIT);
         cy.getTokenBalance({

diff --git a/test/e2e/specs/liquidation.spec.js b/test/e2e/specs/liquidation.spec.js
@@ -786,7 +786,6 @@ describe('Wallet App Test Cases', () => {
 
     it('should cancel the 1IST bid', () => {
       cy.skipWhen(AGORIC_NET !== networks.LOCAL);
-      cy.reload();
 
       cy.contains('Exit').click();
       cy.wait(QUICK_WAIT);

diff --git a/test/e2e/support.js b/test/e2e/support.js
@@ -15,15 +15,20 @@ const balanceUrl =
     : 'http://localhost:1317/cosmos/bank/v1beta1/balances/';
 const COMMAND_TIMEOUT = configMap[network].COMMAND_TIMEOUT;
 
-const agops = '/usr/src/agoric-sdk/packages/agoric-cli/bin/agops';
+const agops = 'agops';
 
 Cypress.Commands.add('addKeys', params => {
   const { keyName, mnemonic, expectedAddress } = params;
   const command = `echo ${mnemonic} | agd keys add ${keyName} --recover --keyring-backend=test`;
 
   cy.exec(command, {
     failOnNonZeroExit: false,
-  }).then(({ stdout }) => {
+  }).then(({ stdout, stderr }) => {
+    if (stderr && !stdout) {
+      cy.task('error', `STDERR: ${stderr}`);
+      throw Error(stderr);
+    }
+    cy.task('info', `STDOUT: ${stdout}`);
     expect(stdout).to.contain(expectedAddress);
   });
 });
@@ -35,7 +40,12 @@ Cypress.Commands.add('setOraclePrice', price => {
       env: { AGORIC_NET },
       timeout: COMMAND_TIMEOUT,
     },
-  ).then(({ stdout }) => {
+  ).then(({ stdout, stderr }) => {
+    if (stderr && !stdout) {
+      cy.task('error', `STDERR: ${stderr}`);
+      throw Error(stderr);
+    }
+    cy.task('info', `STDOUT: ${stdout}`);
     expect(stdout).to.not.contain('Error');
     expect(stdout).to.not.contain('error');
   });
@@ -57,7 +67,12 @@ Cypress.Commands.add('createVault', params => {
     cy.exec(broadcastCommand, {
       env: { AGORIC_NET },
       timeout: COMMAND_TIMEOUT,
-    }).then(({ stdout }) => {
+    }).then(({ stdout, stderr }) => {
+      if (stderr && !stdout) {
+        cy.task('error', `STDERR: ${stderr}`);
+        throw Error(stderr);
+      }
+      cy.task('info', `STDOUT: ${stdout}`);
       expect(stdout).not.to.contain('Error');
     });
   });
@@ -71,7 +86,12 @@ Cypress.Commands.add('placeBidByPrice', params => {
     env: { AGORIC_NET },
     timeout: COMMAND_TIMEOUT,
     failOnNonZeroExit: false,
-  }).then(({ stdout }) => {
+  }).then(({ stdout, stderr }) => {
+    if (stderr && !stdout) {
+      cy.task('error', `STDERR: ${stderr}`);
+      throw Error(stderr);
+    }
+    cy.task('info', `STDOUT: ${stdout}`);
     expect(stdout).to.contain('Your bid has been accepted');
   });
 });
@@ -85,7 +105,12 @@ Cypress.Commands.add('placeBidByDiscount', params => {
     env: { AGORIC_NET },
     timeout: COMMAND_TIMEOUT,
     failOnNonZeroExit: false,
-  }).then(({ stdout }) => {
+  }).then(({ stdout, stderr }) => {
+    if (stderr && !stdout) {
+      cy.task('error', `STDERR: ${stderr}`);
+      throw Error(stderr);
+    }
+    cy.task('info', `STDOUT: ${stdout}`);
     expect(stdout).to.contain('Your bid has been accepted');
   });
 });