feat: remove wallet bridge #202
Conversation
| <div className="w-screen max-w-7xl m-auto"> | ||
| {error ? ( | ||
| <> | ||
| <div className="flex justify-end flex-row space-x-2 items-center mr-6 m-2"> | ||
| {networkDropdown} | ||
| </div> | ||
| <div>Error connecting to chain</div> | ||
| <div>Error connecting to chain!</div> |
| @@ -130,7 +120,7 @@ const CloseVaultDialog = ({ | |||
| {...noticeProps} | |||
| className="overflow-hidden text-interOrange" | |||
| > | |||
| Offer sent to Agoric Smart Wallet for approval. | |||
| Vault has been closed successfully. | |||
There was a problem hiding this comment.
It's only been sent, right? The transaction could still fail. For example if another transaction in flight took out more debt, this pay down to close would not be enough.
There was a problem hiding this comment.
Oh just the variable name is off. Approving assuming you'll revise
There was a problem hiding this comment.
Updated the variable name
| @@ -111,7 +113,7 @@ const ManageVaults = () => { | |||
| ); | |||
| } else if (!chainConnection) { | |||
| popupContent = 'Connect your wallet to manage your vaults.'; | |||
| } else if (vaults?.size === 0) { | |||
| } else if (vaults?.size === 0 || isSmartWalletProvisioned === false) { | |||
There was a problem hiding this comment.
Consider having its own case message. Perhaps "You have no Agoric smart wallet yet."
There was a problem hiding this comment.
I considered that but I'm leaning towards keeping this as is. We already show the dialog, so it's not necessary to tell them twice, and it doesn't matter to them that there's no smart wallet until they actually try to create a vault, where they'll see the "Provision" button in that view.
|
|
||
| const body = ( | ||
| <span> | ||
| To interact with contracts on the Agoric chain, a smart wallet must be |
There was a problem hiding this comment.
For future work: should we have a utility for this in ui-kit? Worth an issue imo
There was a problem hiding this comment.
Possibly for the provisioning fee, though I'm not sure how likely that flow is to change (i.e. if we implement automatic provisioning). We already have a utility for the provision status. I'm not sure if the whole dialog flow is worth making into a component depending on how dapps want to handle it
samsiegart
force-pushed
the
remove-wallet-bridge
branch
from
d247168
to
f9a0084
Compare
fixes #201