feat: allow node selection after connection error #217
Conversation
samsiegart
force-pushed
the
node-selector
branch
from
0b122c8
to
ec5e850
Compare
| setSavedApi(api); | ||
| setSavedRpc(rpc); | ||
| setIsOpen(false); | ||
| window.location.reload(); |
There was a problem hiding this comment.
Is a full page reload necessary here? I guess it doesn't matter much, as a majority of app state is dependent on the rpc + api endpoints.
There was a problem hiding this comment.
Yea it's just taking the easy way out. Otherwise we'd have to recreate the chainStorageWatcher and walletConnection, reset the state, and make sure we clean up all casting followers etc.
There was a problem hiding this comment.
It doesn't provide an entrypoint to the node selector outside of the error dialog, that can be added in a future PR.
It would be nice to see this in the MVP, maybe as the last option in Network Dropdown and/or a url query param (?showConnectionSettings=true) for advanced users. But agree this can come later
refs Agoric/agoric-sdk#8505
refs #211
This adds a "connection settings" button to the chain connection error dialog which allows you to select API and RPC nodes. It saves your selections to local storage, which take priority over whichever nodes are loaded from the network config.
It doesn't provide an entrypoint to the node selector outside of the error dialog, that can be added in a future PR. Also, if you change networks (dev/testnet only, as mainnet doesn't have the network dropdown), it just deletes the saved nodes, instead of saving a map of saved nodes for every network.
Screenshots
Recording
(Animations look choppy in the gif due to compression, but you can try it in the live demo in the comments yourself)
