-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: test cases for vaults ui #251
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like lint is failing, maybe adding an eslintrc like https://github.com/frazarshad/dapp-psm/blob/79bb3102a476b00ca685b75087dd54b659426e60/tests/e2e/.eslintrc.cjs should do the trick?
@samsiegart Thanks for pointing it out. I've addressed the linting issue. I had to add some eslint-specific dependencies and make code changes around that. Turns out, in |
We're close now, lint is passing but
I think we can solve this by ignoring the e2e tests in |
@samsiegart Addressed. Thanks for the assistance. :) |
The PR adds end-to-end test cases for: