Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix e2e tests issues when running with emerynet #382

Merged
merged 7 commits into from
Oct 14, 2024
Merged

fix e2e tests issues when running with emerynet #382

merged 7 commits into from
Oct 14, 2024

Conversation

rabi-siddique
Copy link
Contributor

@rabi-siddique rabi-siddique commented Oct 14, 2024 •
edited
Loading

The PR does the following:

  • Use absolute path for agops in CI.
  • Chores around bringing consistency in running e2e tests between a3p and testnets.
  • Wraps logs in a separate then callback.
  • Adds a retry mechanism for auction-specific test cases.

@rabi-siddique rabi-siddique added liquidation-testing Trigger E2E tests for Liquidation emerynet To trigger Liquidation E2E tests using emerynet and removed liquidation-testing Trigger E2E tests for Liquidation labels Oct 14, 2024
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Oct 14, 2024 •
edited
Loading

Deploying dapp-inter-test with  Cloudflare Pages  Cloudflare Pages

Latest commit: f0ce004
Status: ✅  Deploy successful!
Preview URL: https://3229fa05.dapp-inter-test.pages.dev
Branch Preview URL: https://rs-fix-oracle-prices.dapp-inter-test.pages.dev

View logs

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Oct 14, 2024 •
edited
Loading

Deploying agoric-dapp-inter-emerynet with  Cloudflare Pages  Cloudflare Pages

Latest commit: f0ce004
Status: ✅  Deploy successful!
Preview URL: https://ee83b0e4.agoric-dapp-inter-emerynet.pages.dev
Branch Preview URL: https://rs-fix-oracle-prices.agoric-dapp-inter-emerynet.pages.dev

View logs

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 14, 2024 •
edited
Loading

Network:
Commit: a6010f1
Ref: refs/heads/main
IPFS v1 hash: bafybeifw2fsj7v6jhbyfhb5cubt3d6md6vb6z6vwhh4mkkzgqet42eexle
CF - DWeb - 4EVERLAND

@rabi-siddique rabi-siddique added liquidation-reconstitution-testing Trigger E2E tests for Liquidation-Reconstitution and removed emerynet To trigger Liquidation E2E tests using emerynet labels Oct 14, 2024
@rabi-siddique rabi-siddique changed the title chore: fix: agops path fix e2e tests issues when running with emerynet Oct 14, 2024
@rabi-siddique rabi-siddique added emerynet To trigger Liquidation E2E tests using emerynet and removed liquidation-reconstitution-testing Trigger E2E tests for Liquidation-Reconstitution labels Oct 14, 2024
@rabi-siddique rabi-siddique marked this pull request as ready for review October 14, 2024 11:02
@rabi-siddique rabi-siddique merged commit a6010f1 into main Oct 14, 2024
8 checks passed
@rabi-siddique rabi-siddique deleted the rs-fix-oracle-prices branch October 14, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frazarshad frazarshad frazarshad approved these changes

Assignees
No one assigned
Labels
emerynet To trigger Liquidation E2E tests using emerynet liquidation-testing Trigger E2E tests for Liquidation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rabi-siddique @frazarshad