import ERTP types

.github/workflows/ci.yml

@@ -21,3 +21,4 @@ jobs:
       - run: yarn lint
       - run: yarn test
       - run: yarn docs
+      - run: yarn format --check

package.json

@@ -31,7 +31,7 @@
     "eslint-config-jessie": "^0.0.6",
     "eslint-config-prettier": "^8.8.0",
     "eslint-plugin-html": "^7.1.0",
-    "eslint-plugin-import": "^2.27.5",
+    "eslint-plugin-import": "^2.29.1",
     "eslint-plugin-jsdoc": "^46.2.6",
     "eslint-plugin-jsx-a11y": "^6.7.1",
     "eslint-plugin-no-only-tests": "^3.1.0",

packages/react-components/.eslintrc.js

@@ -17,4 +17,4 @@ module.exports = {
     '@typescript-eslint/no-unused-vars': 'warn',
     'no-console': 'warn',
   },
-}
+};

packages/react-components/.prettierrc

@@ -4,4 +4,4 @@
   "printWidth": 80,
   "endOfLine": "auto",
   "arrowParens": "avoid"
-}
+}

packages/react-components/package.json

@@ -16,7 +16,7 @@
     "./dist/style.css": "./dist/style.css"
   },
   "scripts": {
-    "build": "tsc && vite build",
+    "build": "tsc && NODE_OPTIONS=--max-old-space-size=4096 vite build",
     "lint": "eslint --ext .js,.jsx,.ts,.tsx",
     "lint:fix": "eslint --ext .js,.jsx,.ts,.tsx --fix",
     "test": "vitest run --passWithNoTests",
@@ -51,7 +51,7 @@
     "eslint": "8.46.0",
     "eslint-config-prettier": "9.0.0",
     "eslint-config-standard-with-typescript": "37.0.0",
-    "eslint-plugin-import": "2.28.0",
+    "eslint-plugin-import": "^2.29.1",
     "eslint-plugin-n": "16.0.1",
     "eslint-plugin-promise": "6.1.1",
     "eslint-plugin-react": "7.33.1",

packages/react-components/postcss.config.js

@@ -3,4 +3,4 @@ module.exports = {
     tailwindcss: {},
     autoprefixer: {},
   },
-}
+};

packages/react-components/src/lib/components/AmountInput.tsx

@@ -6,7 +6,7 @@ const noop = () => {
   /* no-op */
 };
 
-type Props = {
+export type AmountInputProps = {
   value: NatValue | null;
   decimalPlaces: number;
   className?: React.HtmlHTMLAttributes<HTMLInputElement>['className'];
@@ -15,7 +15,13 @@ type Props = {
 };
 
 const RenderAmountInput = (
-  { value, decimalPlaces, className, onChange = noop, disabled = false }: Props,
+  {
+    value,
+    decimalPlaces,
+    className,
+    onChange = noop,
+    disabled = false,
+  }: AmountInputProps,
   ref?: Ref<HTMLInputElement>,
 ) => {
   const { displayString, handleInputChange } = useAmountInput({

packages/react-components/src/lib/components/NetworkDropdown.tsx

@@ -4,7 +4,7 @@ import { agoricChain, prettyTestChainName } from '../config/index.js';
 import { ChangeChainCombobox } from '@interchain-ui/react';
 import { useState } from 'react';
 
-type Props = {
+export type NetworkDropdownProps = {
   networkConfigs: NetworkConfig[];
   label?: ChangeChainCombobox['label'];
   size?: ChangeChainCombobox['size'];
@@ -33,7 +33,7 @@ export const NetworkDropdown = ({
   maxHeight,
   size = 'md',
   appearance = 'bold',
-}: Props) => {
+}: NetworkDropdownProps) => {
   const { networkConfig, setNetworkConfig } = useAgoricNetwork();
   assert(
     networkConfig && setNetworkConfig,

packages/react-components/src/lib/components/NodeSelectorModal.tsx

@@ -5,12 +5,15 @@ import { useAgoricNetwork } from '../hooks';
 import BldIcon from '../icons/Bld';
 import type { ChangeEvent } from 'react';
 
-type Props = {
+export type NodeSelectorModalProps = {
   isOpen?: boolean;
   onClose: () => void;
 };
 
-export const NodeSelectorModal = ({ onClose, isOpen = false }: Props) => {
+export const NodeSelectorModal = ({
+  onClose,
+  isOpen = false,
+}: NodeSelectorModalProps) => {
   const { networkConfig, setNetworkConfig } = useAgoricNetwork();
   const defaultRest = networkConfig?.apis?.rest?.at(0);
   const defaultRpc = networkConfig?.apis?.rpc?.at(0);

packages/react-components/src/lib/context/AgoricContext.ts

@@ -1,10 +1,12 @@
 import { createContext } from 'react';
-import {
-  type AmountValue,
-  makeAgoricWalletConnection,
-} from '@agoric/web-components';
+import { makeAgoricWalletConnection } from '@agoric/web-components';
 import type { ChainStorageWatcher } from '@agoric/rpc';
-import type { Brand, Amount, AssetKind } from '@agoric/ertp/src/types';
+import type {
+  Brand,
+  Amount,
+  AssetKind,
+  AmountValue,
+} from '@agoric/ertp/src/types';
 
 export type PurseJSONState<T extends AssetKind> = {
   brand: Brand;

packages/react-components/src/lib/context/AgoricProvider.tsx

@@ -9,14 +9,14 @@ import type { MainWalletBase, WalletConnectOptions } from '@cosmos-kit/core';
 
 import '@interchain-ui/react/styles';
 
-type Props = {
+export type AgoricProviderProps = PropsWithChildren<{
   wallets: MainWalletBase[];
   defaultNetworkConfig: NetworkConfig;
   walletConnectOptions?: WalletConnectOptions;
   onConnectionError?: (e: unknown) => void;
-};
+}>;
 
-export const AgoricProvider = (props: PropsWithChildren<Props>) => {
+export const AgoricProvider = (props: AgoricProviderProps) => {
   return (
     <NetworkProvider defaultNetworkConfig={props.defaultNetworkConfig}>
       <AgoricProviderInner {...props} />
@@ -29,7 +29,7 @@ const AgoricProviderInner = ({
   walletConnectOptions,
   children,
   onConnectionError,
-}: PropsWithChildren<Props>) => {
+}: AgoricProviderProps) => {
   const { networkConfig } = useContext(NetworkContext);
   assert(networkConfig, 'Network config missing from context');
 

packages/react-components/src/lib/context/AgoricProviderLite.tsx

@@ -27,11 +27,11 @@ import { subscribeLatest } from '@agoric/notifier';
 import type { ChainName } from 'cosmos-kit';
 import type { AssetKind } from '@agoric/ertp/src/types';
 
-type Props = {
+export type AgoricProviderLiteProps = PropsWithChildren<{
   chainName?: ChainName;
   useCustomEndpoints?: boolean;
   onConnectionError?: (e: unknown) => void;
-};
+}>;
 
 /**
  * Provides access to Agoric-specific account features such as smart wallet
@@ -48,7 +48,7 @@ export const AgoricProviderLite = ({
   onConnectionError = () => {},
   chainName = 'agoric',
   useCustomEndpoints = true,
-}: PropsWithChildren<Props>) => {
+}: AgoricProviderLiteProps) => {
   const [walletConnection, setWalletConnection] = useState<
     AgoricWalletConnection | undefined
   >(undefined);

packages/react-components/src/lib/hooks/amountInput.ts

@@ -10,7 +10,8 @@ type Args = {
 };
 
 export const useAmountInput = ({ value, decimalPlaces, onChange }: Args) => {
-  const amountString = stringifyValue(value, AssetKind.NAT, decimalPlaces);
+  const amountString =
+    value === null ? '' : stringifyValue(value, AssetKind.NAT, decimalPlaces);
 
   const [fieldString, setFieldString] = useState(
     value === null ? '' : amountString,
@@ -26,7 +27,11 @@ export const useAmountInput = ({ value, decimalPlaces, onChange }: Args) => {
     setFieldString(str);
 
     try {
-      const parsed = parseAsValue(str, AssetKind.NAT, decimalPlaces);
+      const parsed = parseAsValue(
+        str,
+        AssetKind.NAT,
+        decimalPlaces,
+      ) as NatValue;
       onChange(parsed);
     } catch {
       console.debug('Invalid input', str);

packages/react-components/tailwind.config.js

@@ -5,4 +5,4 @@ module.exports = {
     extend: {},
   },
   plugins: [],
-}
+};

packages/react-components/typedoc.json

@@ -0,0 +1,4 @@
+{
+  "extends": ["../../typedoc.base.json"],
+  "entryPoints": ["src/lib/index.ts"]
+}

packages/react-components/vite.config.ts

@@ -1,18 +1,18 @@
-import react from '@vitejs/plugin-react'
-import path from 'node:path'
-import { defineConfig } from 'vitest/config'
-import dts from 'vite-plugin-dts'
-import tailwindcss from 'tailwindcss'
-import { UserConfigExport } from 'vite'
-import { name } from './package.json'
+import react from '@vitejs/plugin-react';
+import path from 'node:path';
+import { defineConfig } from 'vitest/config';
+import dts from 'vite-plugin-dts';
+import tailwindcss from 'tailwindcss';
+import { UserConfigExport } from 'vite';
+import { name } from './package.json';
 
 const app = async (): Promise<UserConfigExport> => {
   /**
    * Removes everything before the last
    * @octocat/library-repo -> library-repo
    * vite-component-library-template -> vite-component-library-template
    */
-  const formattedName = name.match(/[^/]+$/)?.[0] ?? name
+  const formattedName = name.match(/[^/]+$/)?.[0] ?? name;
 
   return defineConfig({
     plugins: [
@@ -31,7 +31,7 @@ const app = async (): Promise<UserConfigExport> => {
         entry: path.resolve(__dirname, 'src/lib/index.ts'),
         name: formattedName,
         formats: ['es', 'umd'],
-        fileName: (format) => `${formattedName}.${format}.js`,
+        fileName: format => `${formattedName}.${format}.js`,
       },
       rollupOptions: {
         external: ['react', 'react/jsx-runtime', 'react-dom', 'tailwindcss'],
@@ -49,7 +49,7 @@ const app = async (): Promise<UserConfigExport> => {
       globals: true,
       environment: 'jsdom',
     },
-  })
-}
+  });
+};
 // https://vitejs.dev/config/
-export default app
+export default app;

packages/rpc/README.md

@@ -3,7 +3,7 @@ For more complete examples and setup see [Agoric/ui-kit](https://github.com/Agor
 ```ts
 import {
   makeAgoricChainStorageWatcher,
-  AgoricChainStoragePathKind as Kind
+  AgoricChainStoragePathKind as Kind,
 } from '@agoric/rpc';
 
 const watcher = makeAgoricChainStorageWatcher(rpc, chainName);
@@ -13,8 +13,8 @@ const stopWatching = watcher.watchLatest<string[]>(
   [Kind.Children, 'published.vaultFactory.managers'],
   managerIds => {
     console.log('Got vault manager IDs:', managerIds);
-  }
-)
+  },
+);
 
 // Stop watching.
 stopWatching();

packages/rpc/package.json

@@ -29,7 +29,7 @@
     "@vitest/coverage-c8": "^0.25.3",
     "axios-mock-adapter": "^1.22.0",
     "eslint": "^8.22.0",
-    "eslint-plugin-import": "^2.26.0",
+    "eslint-plugin-import": "^2.29.1",
     "eslint-plugin-require-extensions": "^0.1.3",
     "happy-dom": "^9.20.3",
     "postinstall-postinstall": "^2.1.0",

packages/rpc/tsconfig.build.json

@@ -1,12 +1,10 @@
 {
-    "extends": "./tsconfig.json",
-    "compilerOptions": {
-        "outDir": "./dist",
-        "noEmit": false,
-        "declaration": true,
-        "declarationMap": true
-    },
-    "exclude": [
-        "test/"
-    ]
+  "extends": "./tsconfig.json",
+  "compilerOptions": {
+    "outDir": "./dist",
+    "noEmit": false,
+    "declaration": true,
+    "declarationMap": true
+  },
+  "exclude": ["test/"]
 }

packages/rpc/tsconfig.json

@@ -2,11 +2,7 @@
   "extends": "../../tsconfig.json",
   "compilerOptions": {
     "useDefineForClassFields": true,
-    "lib": [
-      "DOM",
-      "DOM.Iterable",
-      "ESNext"
-    ],
+    "lib": ["DOM", "DOM.Iterable", "ESNext"],
     "esModuleInterop": false,
     "allowSyntheticDefaultImports": true,
     "allowJs": false,
@@ -16,10 +12,7 @@
     "isolatedModules": true,
     "baseUrl": "src"
   },
-  "include": [
-    "src",
-    "index.ts"
-  ],
+  "include": ["src", "index.ts"],
   "references": [
     {
       "path": "./tsconfig.node.json"

packages/rpc/typedoc.json

@@ -1,8 +1,4 @@
 {
-    "extends": [
-        "../../typedoc.base.json"
-    ],
-    "entryPoints": [
-        "index.ts",
-    ]
+  "extends": ["../../typedoc.base.json"],
+  "entryPoints": ["index.ts"]
 }

packages/web-components/README.md

@@ -7,7 +7,7 @@ import { makeAgoricWalletConnection } from '@agoric/web-components';
 
 const watcher = makeAgoricChainStorageWatcher(rpc, chainName);
 const connection = await makeAgoricWalletConnection(watcher);
-const {pursesNotifier, publicSubscribersNotifier} = chainConnection;
+const { pursesNotifier, publicSubscribersNotifier } = chainConnection;
 
 // Sign an on-chain offer transaction.
 connection.makeOffer(...offer);

packages/web-components/index.js → packages/web-components/index.ts

@@ -1,5 +1,3 @@
-// @ts-check
-
 export { makeAgoricWalletConnection } from './src/wallet-connection/walletConnection.js';
 export {
   agoricRegistryTypes,

packages/web-components/package.json

@@ -18,20 +18,20 @@
     "@agoric/cache": "^0.3.2",
     "@agoric/casting": "^0.4.3-u13.0",
     "@agoric/cosmic-proto": "0.3.0",
-    "@agoric/ertp": "^0.16.2",
+    "@agoric/ertp": "^0.16.3-dev-e2e36cc.0",
     "@agoric/notifier": "^0.6.3-dev-8c14632.0",
     "@agoric/smart-wallet": "^0.5.3",
     "@endo/captp": "^3.1.1",
     "@endo/eventual-send": "^0.17.5",
     "@endo/marshal": "^0.8.5"
   },
   "devDependencies": {
-    "eslint-config-airbnb-base": "15.0.0",
     "@agoric/eslint-config": "0.4.1-u12.0",
     "@agoric/rpc": "^0.9.0",
     "@keplr-wallet/types": "^0.11.37",
     "@typescript-eslint/eslint-plugin": "^7.1.0",
     "eslint": "^8.57.0",
+    "eslint-config-airbnb-base": "15.0.0",
     "ses": "0.18.7",
     "vitest": "^0.34.1"
   },
@@ -47,8 +47,11 @@
       "jsdoc/require-property-description": "off",
       "jsdoc/require-returns": "off",
       "jsdoc/check-tag-names": "off",
+      "jsdoc/require-param-type": "off",
       "jsdoc/tag-lines": "off",
-      "import/no-extraneous-dependencies": "off"
+      "import/no-unresolved": "off",
+      "import/no-extraneous-dependencies": "off",
+      "import/order": "off"
     },
     "parser": "@typescript-eslint/parser",
     "parserOptions": {