build: upgrade Yarn to v4 #105
Conversation
turadg
force-pushed
the
ta/yarn-4
branch
3 times, most recently
from
ec44d6d to
431eb1f
Compare
turadg
force-pushed
the
ta/yarn-4
branch
2 times, most recently
from
ffd8c59 to
437a839
Compare
| @@ -7,9 +7,7 @@ | |||
| "main": "dist/index.js", | |||
| "scripts": { | |||
| "prepack": "tsc --build tsconfig.build.json", | |||
| "lint": "run-s --continue-on-error lint:*", | |||
There was a problem hiding this comment.
run-s doesn't seem to work with yarn 4
There was a problem hiding this comment.
Is yarn lerna obsolete now in the bottom of this file? I'm not sure if yarn 4 has a better way of doing publish.
There was a problem hiding this comment.
I think we can get rid of Lerna eventually, but I don't think it will be very straightforward
| @@ -8,12 +8,12 @@ | |||
| "packages/react-components" | |||
| ], | |||
| "type": "module", | |||
| "packageManager": "yarn@1.22.19", | |||
| "packageManager": "yarn@4.1.1", | |||
| "scripts": { | |||
There was a problem hiding this comment.
I've been manually running yarn workspaces run prepack at the top level when building/linking react-components locally. It might be useful to add a prepack script here now that it's more verbose: yarn workspaces foreach --all --topological run prepack
There was a problem hiding this comment.
good idea. I'll leave for future PR to land this now
| @@ -1,6 +1,5 @@ | |||
| { | |||
| "name": "@agoric/react-components", | |||
| "private": false, | |||
There was a problem hiding this comment.
I can't remember why I added this, I think I was having trouble getting react-components to publish, but it might've been a matter of just adding:
"publishConfig": { "access": "public" }
below. I guess we'll find out, I assume false is the default here.
There was a problem hiding this comment.
yeah, it's the default. This was removed automatically by yarn.
| @@ -31,7 +31,6 @@ describe('stringifyRatio', () => { | |||
| const ethPrice = harden( | |||
| makeRatio( | |||
| 158724n, // value of 1 eth in cents | |||
| // @ts-expect-error fake brand | |||
There was a problem hiding this comment.
Does yarn 4 have an issue with @ts-expect-error?
There was a problem hiding this comment.
I ran into something in merging or rebasing and after having dealt with it several times in in the .ts PR I wanted a quieter solution
closes: #2245 refs: Agoric/agoric-sdk#451 refs: Agoric/ui-kit#105 ## Description Move from Yarn 1 to Yarn 4. Some advantages, - actively maintained - [workspace protocol](https://yarnpkg.com/protocol/workspace) (so we don't have to maintain version numbers in all deps) - [patch protocol](https://yarnpkg.com/protocol/patch) (so we don't need patch-package) - [constraints](https://yarnpkg.com/features/constraints) (e.g. to enforce layering) - path to adopt pnpm-style linker (without changing the UI) (see #1722 ) However this defers workspace protocol until the publishing workflow can support it. ### Security Considerations This does a bulk update of `yarn.lock`. It was automated by Yarn 4. ### Scaling Considerations n/a ### Documentation Considerations I reviewed `yarn` commands in *.md and I think they're all accurate. ### Testing Considerations This could interact with the publishing pipeline. @kriskowal may want to push a draft before we merge. If problems are found, depending on the severity, we could follow up in a separate PR to land this sooner reduce merge conflicts. This was failing on the Windows tests, something about corepack not taking effect. I don't know whether Windows is officially supported by Endo. We've since disabled them. #2243 is the issue restore. ### Compatibility Considerations Some CLI commands are slightly different. We are adopting it across the org so we have to adjust sometime. ### Upgrade Considerations n/a
refs: Agoric/agoric-sdk#451
Description
Upgrade from Yarn v1 to v4
Security Considerations
Bulk update to lockfile. I let Yarn do it.
Scaling Considerations
n/a
Documentation Considerations
no
Testing Considerations
CI