Add progress callback for transferred object keys in copy_files_from #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to hook the key iteration without an override for each provider transfer.
tilman-aiven
requested review from
kmichel-aiven,
dmitry-potepalov and
joelynch
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #192 +/- ##
==========================================
+ Coverage 73.41% 73.48% +0.06%
==========================================
Files 34 34
Lines 4085 4224 +139
==========================================
+ Hits 2999 3104 +105
- Misses 1086 1120 +34 ☔ View full report in Codecov by Sentry. |
aris-aiven
reviewed
Aug 21, 2024
tilman-aiven
force-pushed
the
tilman-transfered-object-keys-progress
branch
from
73ae675
to
9a596fc
Compare
kmichel-aiven
previously requested changes
Aug 21, 2024
tilman-aiven
force-pushed
the
tilman-transfered-object-keys-progress
branch
2 times, most recently
from
688c04f
to
31f4254
Compare
joelynch
approved these changes
Aug 23, 2024
Added callback progress_fn to copy_files_from which tracks the progress of transferred objects with completed and total files. This does not measure the number of bytes in order to avoid a provider based implementation.
tilman-aiven
force-pushed
the
tilman-transfered-object-keys-progress
branch
from
31f4254
to
e030ab6
Compare
aris-aiven
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change - What it does
This adds a callback function in
copy_files_from, which provides the transferred object key with completed and total files.We want to measure the progress of transferred files. However measuring the amount of transferred bytes requires a provider based implementation. Therefore we measure the keys which is provider independent.