Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Commit

Permalink
Merge pull request #317 from Aiven-Open/jeqo/bump-commons-0.12
Browse files Browse the repository at this point in the history
chore: bump commons to 0.12
  • Loading branch information
tvainika authored Oct 10, 2023
2 parents 194ba4a + 4d48fd6 commit c5651c3
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -1 +1 @@
* @aiven/team-helpful-husky @aiven/aiven-open-source
* @aiven-open/team-helpful-husky @aiven-open/aiven-open-source
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -619,9 +619,9 @@ There are four configuration properties to configure retry strategy exists.

### Developing together with Commons library

This project depends on [Common Module for Apache Kafka Connect](https://github.com/aiven/commons-for-apache-kafka-connect). Normally, an artifact of it published to a globally accessible repository is used. However, if you need to introduce changes to both this connector and Commons library at the same time, you should short-circuit the development loop via locally published artifacts. Please follow this steps:
This project depends on [Common Module for Apache Kafka Connect](https://github.com/aiven-open/commons-for-apache-kafka-connect). Normally, an artifact of it published to a globally accessible repository is used. However, if you need to introduce changes to both this connector and Commons library at the same time, you should short-circuit the development loop via locally published artifacts. Please follow this steps:
1. Checkout the `main` `HEAD` of Commons.
2. Ensure the version [here](https://github.com/aiven/commons-for-apache-kafka-connect/blob/main/gradle.properties) is with `-SNAPSHOT` prefix.
2. Ensure the version [here](https://github.com/aiven-open/commons-for-apache-kafka-connect/blob/main/gradle.properties) is with `-SNAPSHOT` prefix.
3. Make changes to Commons.
4. Publish it locally with `./gradlew publishToMavenLocal`.
5. Change the version in the connector's [`build.gradle`](build.gradle) (`ext.aivenConnectCommonsVersion`) to match the published snapshot version of Commons.
Expand Down
6 changes: 3 additions & 3 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ ext {
confluentPlatformVersion = "4.1.4"
// Align with version used by commons
avroConverterVersion = "7.2.2"
aivenConnectCommonsVersion = "0.11.0"
aivenConnectCommonsVersion = "0.12.0"

amazonS3Version = "1.12.542"
amazonSTSVersion = "1.12.560"
Expand Down Expand Up @@ -279,7 +279,7 @@ publishing {
pom {
name = "Aiven's S3 Sink Connector for Apache Kafka"
description = "Aiven's S3 Sink Connector for Apache Kafka"
url = "https://github.com/aiven/s3-connector-for-apache-kafka"
url = "https://github.com/aiven-open/s3-connector-for-apache-kafka"
organization {
name = "Aiven Oy"
url = "https://aiven.io"
Expand All @@ -304,7 +304,7 @@ publishing {
scm {
connection = 'scm:git:git://github.com:aiven/s3-connector-for-apache-kafka.git'
developerConnection = 'scm:git:ssh://github.com:aiven/s3-connector-for-apache-kafka.git'
url = 'https://github.com/aiven/s3-connector-for-apache-kafka'
url = 'https://github.com/aiven-open/s3-connector-for-apache-kafka'
}
}
}
Expand Down

0 comments on commit c5651c3

Please sign in to comment.