Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[infra] Refactored some sh files with python #841

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gz83
Copy link
Collaborator

@gz83 gz83 commented Oct 6, 2024

1.Move *.bat files to //win_scripts/old. These files have not been updated for a long time and are not convenient to use.

2.Rewrite some sh files with python, currently only for the parts applicable to Windows.

3.Some other related changes.

@Alex313031

PTAL

@hocheung-chromium
Copy link
Contributor

Roll again

@gz83 gz83 changed the title Refactored some sh files with python and rewrote some instructions [infra] [docs] Refactored some sh files with python and rewrote some instructions Oct 14, 2024
@Alex313031
Copy link
Owner

@gz83 @hocheung-chromium Can you restore the WIN_CROSS_BUILD_INSTRUCTIONS.txt and WIN_INSTRUCTIONS.txt.

Also the BUILDING_WIN.md has some good changes, but also some ones I don't want and some stuff from upstream that I purposefully excluded.

I want to go through the file myself, but I don't want to lose your changes.

I'm going to save your copy of the modified document, and then have you restore that file. Then I will use Meld and compare mine and your copy of it, and make changes as necessary, then commit it myself with credit at the top for your work.

So basically, restore those two .txt files and restore the BUILDING_WIN.md, and then I will merge this PR.

1.Move *.bat files to //win_scripts/old. These
files have not been updated for a long time and
are not convenient to use.

2.Rewrite some sh files with python, currently
only for the parts applicable to Windows.

3.Some other related changes.
@gz83 gz83 changed the title [infra] [docs] Refactored some sh files with python and rewrote some instructions [infra] Refactored some sh files with python Oct 22, 2024
@gz83
Copy link
Collaborator Author

gz83 commented Oct 22, 2024

@gz83 @hocheung-chromium Can you restore the WIN_CROSS_BUILD_INSTRUCTIONS.txt and WIN_INSTRUCTIONS.txt.

Also the BUILDING_WIN.md has some good changes, but also some ones I don't want and some stuff from upstream that I purposefully excluded.

I want to go through the file myself, but I don't want to lose your changes.

I'm going to save your copy of the modified document, and then have you restore that file. Then I will use Meld and compare mine and your copy of it, and make changes as necessary, then commit it myself with credit at the top for your work.

So basically, restore those two .txt files and restore the BUILDING_WIN.md, and then I will merge this PR.

Done

@Alex313031

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants