Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Styling styling issues #55

Merged
merged 2 commits into from
Sep 10, 2024
Merged

[fix] Styling styling issues #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4be8fa2
Fixed styling issues
AlexJSully Sep 10, 2024
236f2ce
Update gitignore
AlexJSully Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,7 @@

# VS code
.vscode/settings.json
.vscode/launch.json
.vscode/launch.json

# Tests
/coverage
56 changes: 39 additions & 17 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"main": "index.html",
"type": "module",
"devDependencies": {
"eslint": "^9.9.1",
"eslint": "^9.10.0",
"eslint-config-prettier": "^9.1.0",
"eslint-plugin-prettier": "^5.2.1",
"globals": "^15.9.0",
Expand Down
13 changes: 9 additions & 4 deletions src/scripts/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,21 +434,21 @@ class ArticleFiller {

// Change indicators
const appendStr = `
<div class="post" id="featuredArticle${d}">
<div class="l">
<div class="post row" id="featuredArticle${d}">
<div class="col-md-4" style="margin-top: 0.5rem;">
<a
href="index.html?${displayList[d]}"
aria-label="Redirect to ${articleTitle}"
>
<img
src="${url}"
width="134"
class="img-fluid"
loading="lazy"
alt="Thumbnail for ${articleTitle}"
>
</a>
</div>
<div class="r">
<div class="col-md-8" style="margin-top: 0.5rem;">
<h2>
<a
href="index.html?${displayList[d]}"
Expand All @@ -457,6 +457,8 @@ class ArticleFiller {
${articleTitle}
</a>
</h2>
</div>
<div class="col-12" style="margin-top: 0.5rem;">
<p>
${articleSummary}
<a
Expand All @@ -466,6 +468,8 @@ class ArticleFiller {
Read More
</a>
</p>
</div>
<div class="col-12">
<p class="details">
<a
href="index.html?${displayList[d]}"
Expand All @@ -475,6 +479,7 @@ class ArticleFiller {
</a>
</p>
</div>
</div>
</div>
`;

Expand Down
2 changes: 1 addition & 1 deletion src/scripts/index.min.js
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions src/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ img {
display: flex;
float: left;
margin-bottom: 0;
width: 100%;
}

#header .pages li {
Expand Down Expand Up @@ -131,7 +132,7 @@ img {
#header h1 {
clear: both;
float: left;
padding: min(1%, 10px);
padding: min(1%, 10px) 2%;
}

#header .ad {
Expand Down Expand Up @@ -302,7 +303,6 @@ img {
#content .post .r {
padding: 15px 0;
width: 100%;
max-width: 430px;
}

#content .post h2 {
Expand Down
2 changes: 1 addition & 1 deletion src/style.min.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading