Fix dual speed fan feature #1170
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasgeens
approved these changes
May 1, 2023
|
@AlexxIT could you consider looking at that one for next fix version please ? |
|
Yes. Will check when get a time. |
|
Please, include this fix into main version. |
AlexxIT
added a commit
that referenced
this pull request
Feb 16, 2024
|
I have reworked the logic. Now all motor users will have cover enabled by default and fan disabled by default. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
following #1163 and #1073
And the PR #1109 Looks like the getStatus doesn't work properly. Callback still is attached to Cover device and not Fan device
Here is a ix proposal, tested locally