Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /api/webrtc/camera_stream_source #472

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

felipecrs
Copy link
Contributor

@felipecrs felipecrs commented Apr 23, 2023

This functionality has been available in https://github.com/felipecrs/hass-expose-camera-stream-source for a while now, and it has received plenty of good feedback. It seems that several people rely on it to import their cameras from Home Assistant to go2rtc.

I believe it's time to upstream the work now, so maybe it will be easier for people to find it and use it.

I'm adding the same functionality but exposed through a different API endpoint (/api/webrtc/camera_stream_source). If you believe there is a better name for it, I'd be happy to change it.

Naturally, the next step would be to refactor the hass module in go2rtc to use this new endpoint instead of the current approach of reading the Home Assistant .storage files, which should enable more users to import their cameras from Home Assistant to go2rtc.

Not only that, the current module only allows add-on users to import their cameras. The new approach would allow people running go2rtc from anywhere to import their cameras (provided we need to handle credentials).

What do you think?

@AlexxIT AlexxIT force-pushed the master branch 2 times, most recently from 4aa680b to 69cbcda Compare August 24, 2023 18:01
@AlexxIT
Copy link
Owner

AlexxIT commented May 15, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants