ACS-8114 Populate email for new AIS users #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsibilio
requested review from
aonych,
mikolajbrzezinski,
pzhyland,
damianujma and
wojtekswieton
damianujma
approved these changes
Jun 7, 2024
aonych
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For new realms on Keycloak 24 the
emailhas become a required user profile field. To make sure our tests work both with migrated realms and entirely new realms (such as the one that is being used by Terraform environments), it would be better to always populate the email.This change especially makes sense to me as the email is already being populated for the Alfresco test users within ACS, so there's probably no good reason to not mirror that information onto AIS as well.
Ref: