Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use prototype table component on Environments overview #1254

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

joetorsney
Copy link
Contributor

This PR is for working on an improved data table component. As it stands, it replaces the table in the environments overview with a prototype low-level table component, so features such as sorting and filtering are not yet implemented. The purpose of working on this component is to improve the API for developers by bringing it more in line with existing open source components that use a column-oriented API.

I DON'T have JIRA ticket

  • explain what this PR does
  • if it is a new feature, explain how you plan to use it
  • tests are added
  • documentation was updated or added

Notable changes for users:

  • The table isn't ready for users yet

Notable changes for developers:

  • Removes the current ActiveColumns object and introduces ColumnModel and cellRenderers, separating the job of manipulating the data to display in a column, and rendering it in the view.
  • Demonstrates how custom column models can be made by implementing the ColumnModel interface for the Environment's status
  • Demonstrates how the TableModel type can be used to construct EnvironmentsTableModel, organising columns in the table.
  • Demonstrates how the CellRenderers type can be used to create evironmentTableRenderers to render the data in the table.
  • Retains functionality in the previous table component where rows can have unique keys, CSS Classes, and configuration passed to h() based on the row data.

Changes made to the database:

  • None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant