[O2B-532] Use time range filter for run start stop #1482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinboulais
force-pushed
the
feature/O2B-532/use-time-range-filter-for-run-start-stop
branch
from
7d740bf
to
30e512c
Compare
martinboulais
force-pushed
the
feature/O2B-532/use-time-range-filter-for-run-start-stop
branch
3 times, most recently
from
959ebe0
to
0b8afc8
Compare
martinboulais
force-pushed
the
feature/O2B-532/use-time-range-filter-for-run-start-stop
branch
from
0b8afc8
to
c18389f
Compare
martinboulais
force-pushed
the
feature/O2B-532/use-time-range-filter-for-run-start-stop
branch
from
7ce8761
to
350e886
Compare
…ime-range-filter-for-run-start-stop
xsalonx
requested changes
Jun 3, 2024
Comment on lines
14
to
18
| import { timeRangeFilter } from '../common/filters/timeRangeFilter.js'; | ||
|
|
||
| let today = new Date(); | ||
| today.setMinutes(today.getMinutes() - today.getTimezoneOffset()); | ||
| [today] = today.toISOString().split('T'); |
There was a problem hiding this comment.
What's the purpose of this?
There was a problem hiding this comment.
Probably debug garbage, removed
Comment on lines
188
to
189
| ret.date = formatTimestampForDateTimeInput(min + MILLISECONDS_IN_ONE_DAY, this._seconds).date; | ||
| } else { |
There was a problem hiding this comment.
maybe minTimestamps or something instead of min, the same with max
Comment on lines
212
to
213
| const ret = {}; | ||
|
|
| } | ||
| if (this.o2endFilterTo !== '') { | ||
| this.activeFilters.push('O2 End to'); | ||
| } | ||
| if (this._runDurationFilter !== null) { |
There was a problem hiding this comment.
Indeed, deleted
Comment on lines
+735
to
738
| * @return {EorReasonFilterModel} the run type filtering model | ||
| */ | ||
| get eorReasonsFilterModel() { | ||
| return this._eorReasonsFilterModel; |
There was a problem hiding this comment.
I think that you can also rename the field to singular
There was a problem hiding this comment.
I just fixed the docblock, this would be a bit too much refactoring
test/public/defaults.js
Outdated
Comment on lines
715
to
717
| /** | ||
| * Return the selector for all the inputs composing a period inputs selectors | ||
| * |
There was a problem hiding this comment.
Return selectors for all inputs composing a period input ?
…ime-range-filter-for-run-start-stop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a JIRA ticket
Notable changes for users: