[deps] Migration to new eslint v9 to flat configuration #1676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinboulais
requested changes
Jul 25, 2024
Comment on lines
+28
to
+29
| * @param {Sequalize} sequalize sequalize instance | ||
| * @param {Sequalize.Transaction} sequalize.transaction transaction to use |
Comment on lines
+38
to
+41
| /** | ||
| * @param {(boolean|{from: boolean, to: boolean})} [configuration.required] defines if the from/to dates are required | ||
| * (true means both are required) | ||
| * @param {boolean} [configuration.seconds=false] states if the input has granularity up to seconds (if not, granularity is minutes) |
There was a problem hiding this comment.
I'm not sure that param make sense out of function signature
| @@ -38,7 +38,8 @@ import { StatefulComponent } from '../../StatefulComponent.js'; | |||
| export class DateTimeInputComponent extends StatefulComponent { | |||
| /** | |||
| * Constructor | |||
| * @property {DateTimeInputComponentVnode} vnode the component's vnode | |||
| * @param {DateTimeInputComponentVnode} vnode the component's vnode | |||
| * @param {DateTimeInputComponentAttrs} vnode.attrs the component's attributes | |||
There was a problem hiding this comment.
I suppose this should not be needed because the type is explicit, not object?
| // eslint-disable-next-line require-jsdoc | ||
| oncreate: function ({ dom }) { | ||
|
|
||
| oncreate: ({ dom }) => { |
There was a problem hiding this comment.
If you do this, the this in the function will not correspond to the vnode state, which will lead to weird behavior if the function is used in several places at the same time. This applies to all these functions
Comment on lines
+179
to
+184
| /** | ||
| * @param {number[]} [options.filter.ids] quality control flag ids to filter with | ||
| * @param {boolean} [options.filter.bad] quality control flag boolean to filter bad or not-bad QC flags | ||
| * @param {boolean} [options.filter.archived] quality control flag boolean to filter archived or not-archived QC flags | ||
| * @param {string[]} [options.filter.names] quality control flag type name to filter with, single token is treated as pattern | ||
| * @param {string[]} [options.filter.methods] quality control flag type method to filter with, single token is treated as pattern |
There was a problem hiding this comment.
Same here, not sure the param applies for an object, it might be @type instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I DON'T have JIRA ticket
Notable changes for users:
Notable changes for developers:
Changes made to the database: