Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O2B-1374] Store only environments with bookkept flag to true #1776

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

martinboulais
Copy link
Collaborator

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • Environments with bookkept: false in configuration are not stored

@martinboulais martinboulais self-assigned this Oct 7, 2024
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 11.11111% with 8 lines in your changes missing coverage. Please review.

Project coverage is 43.87%. Comparing base (e03a151) to head (ef55087).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
lib/server/kafka/AliEcsSynchronizer.js 12.50% 7 Missing ⚠️
lib/server/services/run/RunService.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1776      +/-   ##
==========================================
+ Coverage   43.69%   43.87%   +0.18%     
==========================================
  Files         889      889              
  Lines       15733    15739       +6     
  Branches     2931     2933       +2     
==========================================
+ Hits         6874     6905      +31     
+ Misses       8859     8834      -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martinboulais martinboulais force-pushed the mboulais/O2B-1374/use-bookkept-ecs-flag branch from 644ae84 to 1cd9e51 Compare October 7, 2024 12:20
@martinboulais martinboulais marked this pull request as ready for review October 7, 2024 12:35
@martinboulais martinboulais merged commit 3aa7b14 into main Oct 7, 2024
22 of 23 checks passed
@martinboulais martinboulais deleted the mboulais/O2B-1374/use-bookkept-ecs-flag branch October 7, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant