Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O2B-1387] Display lumi information on LHC fill details page #1782

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

martinboulais
Copy link
Collaborator

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • Display colliding bunches and luminosity on fills details page

Notable changes for developers:

  • N/A

Changes made to the database:

  • N/A

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 43.82%. Comparing base (c6ba263) to head (764c214).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...cFills/Detail/commonLhcFillDisplayConfiguration.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1782      +/-   ##
==========================================
- Coverage   43.82%   43.82%   -0.01%     
==========================================
  Files         889      889              
  Lines       15761    15762       +1     
  Branches     2939     2940       +1     
==========================================
  Hits         6907     6907              
- Misses       8854     8855       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martinboulais martinboulais merged commit 5b50f8c into main Oct 11, 2024
22 of 23 checks passed
@martinboulais martinboulais deleted the mboulais/O2B-1387/display-lumi-on-fll-page branch October 11, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant