Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O2B-1365] Disable GAQ summary if not all detectors have full coverage #1784

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

xsalonx
Copy link
Collaborator

@xsalonx xsalonx commented Oct 14, 2024

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

Notable changes for developers:

Changes made to the database:

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 30.28%. Comparing base (c4e45b7) to head (ec92f8d).

Files with missing lines Patch % Lines
lib/database/repositories/QcFlagRepository.js 0.00% 2 Missing ⚠️
...Runs/RunPerDataPass/RunsPerDataPassOverviewPage.js 0.00% 1 Missing ⚠️
...erver/services/qualityControlFlag/QcFlagService.js 85.71% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (c4e45b7) and HEAD (ec92f8d). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (c4e45b7) HEAD (ec92f8d)
14 12
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1784       +/-   ##
===========================================
- Coverage   43.90%   30.28%   -13.63%     
===========================================
  Files         891      891               
  Lines       15811    15814        +3     
  Branches     2952     2955        +3     
===========================================
- Hits         6942     4789     -2153     
- Misses       8869    11025     +2156     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant