Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O2B-532] Create a reusable filtering system #832

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

martinboulais
Copy link
Collaborator

@martinboulais martinboulais commented Dec 13, 2022

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for developers:

  • A simplified and reusable frontend filtering system has been set-up

@martinboulais martinboulais changed the title Feature/o2 b 532/factorize filtering [O2B-532] Create a reusable filtering system Dec 13, 2022
@martinboulais martinboulais force-pushed the feature/O2B-532/factorize-filtering branch 3 times, most recently from a5b2181 to 9a9e448 Compare December 13, 2022 14:49
@martinboulais martinboulais self-assigned this Dec 15, 2022
@martinboulais martinboulais force-pushed the feature/O2B-532/factorize-filtering branch 2 times, most recently from 80d6648 to a65c4fe Compare January 19, 2023 14:43
@martinboulais martinboulais force-pushed the feature/O2B-532/factorize-filtering branch from a65c4fe to ef44cca Compare February 2, 2023 14:01
@martinboulais martinboulais force-pushed the feature/O2B-532/factorize-filtering branch 2 times, most recently from c32ba36 to a7fad30 Compare March 1, 2023 10:55
@martinboulais martinboulais force-pushed the feature/O2B-532/factorize-filtering branch 3 times, most recently from 9119426 to 06b9a15 Compare April 25, 2023 08:59
@martinboulais martinboulais force-pushed the feature/O2B-532/factorize-filtering branch from 06b9a15 to aa4f561 Compare November 29, 2023 13:48
@martinboulais martinboulais force-pushed the feature/O2B-532/factorize-filtering branch 2 times, most recently from 858366b to 4c9d62b Compare January 23, 2024 11:08
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 62 lines in your changes are missing coverage. Please review.

Project coverage is 44.46%. Comparing base (24ddf8b) to head (6bd7741).
Report is 407 commits behind head on main.

❗ Current head 6bd7741 differs from pull request most recent head 0ab6ff5. Consider uploading reports for the commit 0ab6ff5 to get more accurate results

Files Patch % Lines
...public/components/Filters/common/FilteringModel.js 0.00% 38 Missing ⚠️
lib/public/utilities/serializeQueryParameters.js 0.00% 24 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #832      +/-   ##
==========================================
- Coverage   48.78%   44.46%   -4.32%     
==========================================
  Files         528      773     +245     
  Lines        7968    12765    +4797     
  Branches     1477     2290     +813     
==========================================
+ Hits         3887     5676    +1789     
- Misses       4081     7089    +3008     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martinboulais martinboulais force-pushed the feature/O2B-532/factorize-filtering branch 2 times, most recently from 8fe30d8 to 6bd7741 Compare March 28, 2024 18:15
@martinboulais martinboulais force-pushed the feature/O2B-532/factorize-filtering branch from 6bd7741 to 85b3be4 Compare April 17, 2024 13:30
@martinboulais martinboulais force-pushed the feature/O2B-532/factorize-filtering branch from 85b3be4 to 0ab6ff5 Compare April 22, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant