Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Make task manager eventStream thread safe #524

Merged
merged 1 commit into from
Mar 8, 2024
Merged

[core] Make task manager eventStream thread safe #524

merged 1 commit into from
Mar 8, 2024

Conversation

teo
Copy link
Member

@teo teo commented Mar 5, 2024

No description provided.

@teo teo requested review from knopers8 and justonedev1 March 5, 2024 14:06
justonedev1
justonedev1 reviewed Mar 7, 2024
View reviewed changes
Copy link
Collaborator

@justonedev1 justonedev1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems ok if eventStream is the only part that needs to be thread safe. However, I have few nitpicks, which I did not understand how those got there.

core/environment/eventStream.go Show resolved Hide resolved
core/environment/environment.go Show resolved Hide resolved
@teo teo merged commit 4db08d1 into master Mar 8, 2024
2 checks passed
@teo teo deleted the OCTRL-859 branch March 8, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justonedev1 justonedev1 justonedev1 approved these changes

@knopers8 knopers8 Awaiting requested review from knopers8

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teo @justonedev1