OCTRL-901 Document the order of actions performed during SOR and EOR #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teo
requested changes
May 31, 2024
docs/handbook/operation_order.md
Outdated
Comment on lines
24
to
27
| ### before_event | ||
|
|
||
| - `before_event` hooks are executed | ||
|
|
There was a problem hiding this comment.
Thank you for starting this. I've double checked now and it looks like we do not support generic targets like before_event or leave_state, all the targets must be explicit like before_START_ACTIVITY and leave_CONFIGURED. The order reported in configuration.md refers to the documentation of the FSM package, but we've since implemented our own callback management. The order reported there is still correct, except the generic targets are not supported.
There was a problem hiding this comment.
Thanks, I wasn't aware. I will update the doc.
teo
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we are at the stage where things have settled down and there is a finite number of changes expected to such a document (namely: removing BKP and Kafka plugins calls, possibly moving CCDB plugin calls). One could even consider filling the hooks automatically, based on the information parsed from
readout-dataflow.yaml, but I would leave that for later.The reason for this document is also a request from users to know what are SOSOR, EOSOR, SOEOR, EOEOR timestamps exactly.