[core] test environment's FSM, handling hooks and fix discovered issues #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knopers8
commented
Jun 27, 2024
core/environment/fsm_test.go
Outdated
| Expect(v).To(Equal("true")) | ||
| }) | ||
|
|
||
| It("should return an error if a critical hook times out", func(ctx SpecContext) { |
There was a problem hiding this comment.
@teo could please cross-check this case and tell me if I am missing something here? It fails for some reason - the call hangs infinitely and the timeout mechanism does not kick in (I added a SpecTimeout to avoid having CI hang).
teo
reviewed
Jun 28, 2024
teo
reviewed
Jun 28, 2024
The fixes being: - set run_end_completion_time_ms also at the end of GO_ERROR transition - document that the ECS does not abort the call execution upon timeout, merely passes the parameter to the call - avoid a crash if the FSM.Event() is called without providing a Transition
knopers8
changed the title
teo
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.