[core] Set run timestamps before executing triggers with weight 0 #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It has to come with AliceO2Group/ControlWorkflows#655 |
teo
previously approved these changes
Jul 9, 2024
knopers8
changed the title
|
I tested it on staging with DCS, TRG, ODC, CCDB, BKP, DD, Kafka plugins enabled with a SYNTH 650kHz pp configuration. EMC, CPV, PHS, TRD detectors had to be excluded to allow for trigger to start. I confirmed that the order of plugin execution remained the same. I had to add one fix (delete run number after positive STOP_ACTIVITY hooks are called), which allowed CCDB RunStop to still work correctly. Otherwise, all the plugin logs remained the same as before the changes. It's good to go as far as I am concerned. |
teo
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I still want to test it with TRG plugin enabled, but otherwise, it seems already OK.