Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added logging filters for IL #595

Merged
merged 1 commit into from
Jul 18, 2024
Merged

added logging filters for IL #595

merged 1 commit into from
Jul 18, 2024

Conversation

justonedev1
Copy link
Collaborator

I had to change how directhook is created, because when it is triggered from init() it just uses default values all the time and it isn't settable. So I moved it from init() to main() after config is being loaded and parsed.

@justonedev1 justonedev1 requested review from knopers8 and teo July 17, 2024 12:17
@@ -38,6 +38,7 @@ import (

"github.com/AliceO2Group/Control/common/utils"
"github.com/sirupsen/logrus"
"github.com/spf13/viper"
Copy link
Member

@teo teo Jul 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The inconvenience here is that you've just pulled viper as a dependency of the executor by way of DirectHook, and the executor doesn't even use Viper. I don't know how fat Viper is in absolute terms, but it's a fairly comprehensive library with over a dozen of its own dependencies. So far I've mostly tried to keep the executor small and light as much as possible to ensure fast copying to the Mesos sandbox and startup (and even with that, it's up to 28MB now). Most likely it's not a big deal, but it would be good if you could check the effect of this change on binary size, and if significant, try to find a way to avoid the added dependency.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, looks like I did that recently by using utils.TimeTrack in the executor (and only this so far, AFAICT), so a Viper dependency is already there, unfortunately. I think it would still be good to keep Viper out of the executor, but it's probably out of scope of this logging effort.

@teo teo merged commit 03a5022 into master Jul 18, 2024
2 checks passed
@teo teo deleted the debug_logging branch July 18, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants