Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Emit environment events from CreateAutoEnvironment #605

Merged
merged 1 commit into from
Sep 3, 2024
Merged

[core] Emit environment events from CreateAutoEnvironment #605

merged 1 commit into from
Sep 3, 2024

Conversation

teo
Copy link
Member

@teo teo commented Sep 2, 2024

No description provided.

knopers8
knopers8 approved these changes Sep 2, 2024
View reviewed changes
Copy link
Collaborator

@knopers8 knopers8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, I thought BKP already had moved the de-duplicated call.

@teo teo merged commit 157f3b3 into master Sep 3, 2024
2 checks passed
@teo teo deleted the auto-environment-events branch September 3, 2024 08:27
@teo
Copy link
Member Author

teo commented Sep 3, 2024

Huh, I thought BKP already had moved the de-duplicated call.

It's not on BK to do so, they can only receive events through Kafka. It's on the GUI to stop calling NewAutoEnvironment and consuming the gRPC response stream in favour of calling NewEnvironmentAsync and consuming from Kafka.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knopers8 knopers8 knopers8 approved these changes

@justonedev1 justonedev1 Awaiting requested review from justonedev1

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teo @knopers8